[PATCH] Improve KShortcutDialog construction time

David Faure faure at kde.org
Thu Apr 24 18:44:46 BST 2008


On Thursday 24 April 2008, Andreas Hartmetz wrote:
> >
> > > - (0009) Cache translated names for the shortcut item's display role to
> > > avoid creating new KLocalizedString instances every time.  I'm not sure
> > > why this is translated in the first place since the text for the
> > > translation is just "%1" which is substituted by the action's text.
> >
> > Ask svn annotate for who wrote this line; but indeed I can't see why a
> > translator
> > would want to change this.
> 
> The code we are talking about was recently refactored by mjansen - if
> the "translation" is not a very recent change you might have to check
> out an old version and use svn annotate on that, or do something
> similar in websvn.

No need to check out anything (slow!).
You can go back in time as many times as you need by using svn ann -rN filename.cpp
where N is: the revision showed by svn annotate minus 1.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list