[PATCH] Improve KShortcutDialog construction time

[Andreas Hartmetz]

>
> > - (0009) Cache translated names for the shortcut item's display role to
> > avoid creating new KLocalizedString instances every time.  I'm not sure
> > why this is translated in the first place since the text for the
> > translation is just "%1" which is substituted by the action's text.
>
> Ask svn annotate for who wrote this line; but indeed I can't see why a
> translator
> would want to change this.

The code we are talking about was recently refactored by mjansen - if
the "translation" is not a very recent change you might have to check
out an old version and use svn annotate on that, or do something
similar in websvn.

> However this optimization seems superfluous to me - do you really gain
> anything
> from this code obfuscation? Note that it also breaks runtime language
> change.
>
Arrr, I should have noticed that too.