[FEATURE] KNotify support for galago Notifications spec

Dmitry Suzdalev dimsuzkde at gmail.com
Thu Apr 24 15:57:41 BST 2008


Here's an updated patch - this time it closes shown popups if there are any while 
switching to DBus method. To make it easier for you to find the change its only these 
lines that were added to slotServiceOwnerChanged():

// delete existing popups if any
// NOTE: can't use qDeletaAll here, because it can happen that
// some passive popup auto-deletes itself and slotPopupDestroyed
// will get called *while* qDeleteAll will be iterating over QMap
// and that slot will remove corresponding key from QMap which will
// break qDeleteAll.
// This foreach takes this possibility into account:
foreach ( int id, m_popups.keys() )
	delete m_popups.value(id,0);
m_popups.clear();

Dmitry.

P.S. Sorry for not replying to the right mail in the tree, i've this thread's mails 
splitted between my home computer and work computer :) This supposed to be a reply to 
the last Olivier's mail.




More information about the kde-core-devel mailing list