[FEATURE] KNotify support for galago Notifications spec

Thiago Macieira thiago at kde.org
Wed Apr 23 13:29:48 BST 2008


On Wednesday 23 April 2008 13:56:08 Dmitry Suzdalev wrote:
> OK, here's an updated patch to accomodate Olivier & Aaron's notes.
> It contains the folowing changes:
>
> 1. DBus service name, interface name, object path were renamed from
> "Notifications" to "VisualNotifications"
> (we decided on this name with aseigo. IMHO, PopupServer not suits every
> possible application - it is not necessarily will be a popups :) )
>
> 2. Correctly call KNotify's "finished(id)" when switching from DBus to
> Native method and also when DBus signals that notification has been closed
> - as noticed by Gof, this is the right thing to do to keep things clear on
> knotify side, thanks.
>
> If there will be no more suggestions/objections this time, can I commit?
> Or should I wait some more? :)

Patch looks good from the D-Bus side of it.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080423/2496190c/attachment.sig>


More information about the kde-core-devel mailing list