[FEATURE] KNotify support for galago Notifications spec

Olivier Goffart ogoffart at kde.org
Tue Apr 22 19:11:00 BST 2008


Le lundi 21 avril 2008, Dmitry Suzdalev a écrit :
> On Tuesday 22 April 2008 00:48:50 Olivier Goffart wrote:

> > Also please don't use "Notification" in the interface name, but instead
> > something like "PopupServer"
>
> Why? galago-spec says that interface should be named Notifications, that's
> why I called it like this. What's the reason not to follow it  here?
> Or did I get something wrong?

To avoid the confusion with knotify itself.

> > You need to emit finished(id) when the popup is closed by the server.
> > Otherwhise, you may leak memory for perssistant notifications,  both in
> > knotify and in the application.
>
> Ooops, seems like i missed this. You mean I should call finished(id) in
> closeNotificationDBus?

No.
You should emit finished(id) when the popup server notify you the popup has 
been closed.
(or when cleaning the map when switching method)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080422/438bdd80/attachment.sig>


More information about the kde-core-devel mailing list