[PATCH] Set program icon name by KAboutData

Lubos Lunak l.lunak at suse.cz
Mon Apr 21 18:34:41 BST 2008


On Monday 21 of April 2008, Aaron J. Seigo wrote:
> On Monday 21 April 2008, Lubos Lunak wrote:
> > On Monday 21 of April 2008, Aaron J. Seigo wrote:
> > > On Sunday 20 April 2008, Friedrich W. H. Kossebau wrote:
> > > > Which could ask me to adapt the whole file, as I wrote the code by
> > > > example (TM). But that would kill "svn blame". So now go for mixed
> > > > style in a file?
> > >
> > > when we first came to the agreement for the kdelibs style it was also
> >
> >  Just curious, the agreement part was when Zack posted the proposal in a
> > way that basically dismissed any discussion of it or when everybody got
> > tired of the flamewar and the Qt style then got pushed in?
>
> for those who weren't around at the time, i'll respond to this:
>
> this is a mischaracterization: it dismisses the fact (emphasis on *fact*)
> that when first discussed in Trysil there was overwhelming, though not
> unanimous, support

 Sorry: http://lists.kde.org/?l=kde-core-devel&m=115348018523989&w=2

 Also, the support was for a common style (emphasis on *a*) with unclear range 
of pickiness (both in scale and enforcing), with the details to be sorted out 
on k-c-d.

 That's how I remember it. I can't see how I could have possibly voted on just 
forcing the Qt coding style on people, for various reasons (like TT needing 4 
versions to get their style at least somewhat right 
http://lists.kde.org/?l=kde-core-devel&m=115342363130285&w=2 or people 
working regularly on both Qt and kdelibs probably being possible to count on 
one hand).

 Just for the record, I was voting witht the idea of eventually coming to 
something with a couple of basic rules like '4 spaces, no tabs' that actually 
make a difference and a couple of additional recommendations. Search me how 
enforcing such a useless (and inconsistent) rule like insisting on 'if (foo) 
{ \n 1 line \n }' helps anything.

> and the dissenting opinion on k-c-d after that was not 
> significant enough (in actual objections, not volume) to disuade the move
> to a common style.

 Yes, that's exactly what I meant by basically dismissing any discussion.

> ow here's a possible shocker for you: i don't really like the Qt style
> myself on a number of points.

 That's why you're so picky about it even in Plasma, right? But anyway, this 
is irrelevant.

> here's the non-shocker: i find that my involvement in a *group* project
> outweighs my personal preferences. at some point, there's a maturity that
> should be applied to working with others that outweighs personal
> preferences when reasonable. i completely respect your coding style in
> "your" projects (e.g. kwin), but kdelibs does not have that sort of
> ownership. it's shared, both in theory as well as in practice.

 And here's a possible shocker for you: I regularly deal or have dealt with 
more than five different styles, including Waldo's crazy indent-by-3-spaces 
or Gwenview's indent-by-tab (for which I actually hand-edited every patch 
before posting it) and I could have lived with that. I used my own {} style 
only for few new classes in kdelibs (and nobody really touches those besides 
me, regardless of how they're formatted), and the only thing I've reformatted 
that way was KWin, after 2(?) years which it was again basically a one-man 
show. So don't teach me on personal preferences.

 My problem here is not that. My problem is that this was about somebody's 
personal preference and everything else got ignored 
(http://lists.kde.org/?l=kde-core-devel&m=115340952719876&w=2 and others).

> now ... this is a discussion that happened quite a while ago, and bringing
> it up yet again is pretty lame. having to re-affirm some consensus every N

 wp: consensus :  a) general agreement , b) the judgment arrived at by most of 
those concerned +++ Out of cheese error. Redo from start. +++

> months is not very respectful of project member's time, does not scale and
> as a general mechanism to "eventually get my way" it's very non-productive
> (i need a t-shirt that says, "i'm more patient than you are obstinant")
>
> every decision will not be agreeable to you. i have my own list of things i
> disagree with, too. i'm sure everyone does. and that's ok. we generally
> agree on most things. bringing up issues over and over just to rehash them
> for the Nth time is, imho, not ok.
>
> in that sense, i completely respect Ossi's recent email in a thread where
> he said, "unless there is something new to be added to the conversation, i
> won't support the conversation happening again."

 Actually, fine with me. Technically, there is no coding style one can force 
on anybody anyway (there was no agreement on forcing it and the policy itself 
is pretty clear on this as well), so I suppose ignoring can go both ways.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz




More information about the kde-core-devel mailing list