[PATCH] Set program icon name by KAboutData
Aaron J. Seigo
aseigo at kde.org
Mon Apr 21 17:57:15 BST 2008
On Monday 21 April 2008, Lubos Lunak wrote:
> On Monday 21 of April 2008, Aaron J. Seigo wrote:
> > On Sunday 20 April 2008, Friedrich W. H. Kossebau wrote:
> > > Which could ask me to adapt the whole file, as I wrote the code by
> > > example (TM). But that would kill "svn blame". So now go for mixed
> > > style in a file?
> >
> > when we first came to the agreement for the kdelibs style it was also
>
> Just curious, the agreement part was when Zack posted the proposal in a
> way that basically dismissed any discussion of it or when everybody got
> tired of the flamewar and the Qt style then got pushed in?
for those who weren't around at the time, i'll respond to this:
this is a mischaracterization: it dismisses the fact (emphasis on *fact*) that
when first discussed in Trysil there was overwhelming, though not unanimous,
support and the dissenting opinion on k-c-d after that was not significant
enough (in actual objections, not volume) to disuade the move to a common
style. Zack's initial approach on the list was unfortunately heavy handed,
but throwing out the idea just because someone isn't a diplomatic genius is
stupid.
ow here's a possible shocker for you: i don't really like the Qt style myself
on a number of points.
here's the non-shocker: i find that my involvement in a *group* project
outweighs my personal preferences. at some point, there's a maturity that
should be applied to working with others that outweighs personal preferences
when reasonable. i completely respect your coding style in "your" projects
(e.g. kwin), but kdelibs does not have that sort of ownership. it's shared,
both in theory as well as in practice.
now ... this is a discussion that happened quite a while ago, and bringing it
up yet again is pretty lame. having to re-affirm some consensus every N
months is not very respectful of project member's time, does not scale and as
a general mechanism to "eventually get my way" it's very non-productive (i
need a t-shirt that says, "i'm more patient than you are obstinant")
every decision will not be agreeable to you. i have my own list of things i
disagree with, too. i'm sure everyone does. and that's ok. we generally agree
on most things. bringing up issues over and over just to rehash them for the
Nth time is, imho, not ok.
in that sense, i completely respect Ossi's recent email in a thread where he
said, "unless there is something new to be added to the conversation, i won't
support the conversation happening again."
> > > I personally would use the kdelibs coding style only for completely new
> > > files
> >
> > one of the reasons for having a style guide is global consistency, though
>
> And the other is that you, with all the things you manage to do, still
> feel bored and have time to point out every single space wrong to others?
well, actually, no. in that massive 50k patch posted to panel-devel this
morning i actually made exactly one general comment about coding style. i
spent probably 15s noting a general style issue and at least half an hour
going through the patch itself and commenting on the code.
i am consistent about noting patches that have such issues, though that's
always a secondary concern to the actual code itself. i'm not sure when
consistency became something to accuse someone of in a negative way, but
please rest assured that i don't spend much time in my day on the issue. when
reading a patch for its correctness, these issues are not hard to spot and i
make note of them as i go. it's a side effect of reading patches, not the
primary effect.
i've probably spent more time on this thread than i have on whitespace issues
in the last two months combined, btw ;)
> It's really such a pity none of these people with magic time abilities have
> ever written it down into some Clones-HOWTO. I'm going to need it too, the
> day somebody starts picking up on my patches.
i think dfaure invented the Clones technique. ;)
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080421/6516b09a/attachment.sig>
More information about the kde-core-devel
mailing list