[PATCH] Set program icon name by KAboutData

Friedrich W. H. Kossebau kossebau at kde.org
Sun Apr 20 21:09:43 BST 2008


Am Sonntag, 20. April 2008, um 00:13 Uhr, schrieb Olivier Goffart:
> Le samedi 19 avril 2008, Friedrich W. H. Kossebau a écrit :
> > Attached patch extends KAboutData about the property programIconName and
> > makes KApplication use that property.
> >
> > Okay to apply on next Monday? I will also adapt all programs which
> > directly set the icon.
>
> I don't like the word "program" but it's consistant with the rest of the
> KAboutData API.  (component would be more accurate)

Yes, will add a KDE5 note about this somewhere there.

> You are missing the @since 4.1
> You should document that the default value is the name of the component

@since was even contained in newer patch I missed to pick up. Which also 
contains unit test coverage :) Default value is mentioned in the 
setProgramIconName(), but as you missed it I will also add a note to 
programIconName(), a better place for all property comments indeed.

Thanks, so will commit tomorrow.
Friedrich




More information about the kde-core-devel mailing list