[PATCH] Set program icon name by KAboutData
Aaron J. Seigo
aseigo at kde.org
Sat Apr 19 23:19:28 BST 2008
On Saturday 19 April 2008, Friedrich W. H. Kossebau wrote:
> Okay to apply on next Monday?
+1 from me.
btw, this:
+ if (!d->programIconName.isEmpty())
+ return d->programIconName;
+ return appName();
is missing {}s as per the kdelibs coding style enforcing that one even single
line if's.
(and not that it matters *one bit* =) but as i personally like to avoid
negatives in conditionals, i'd write it as:
if (d->programIconName.isEmpty()) {
return appName();
}
return d->programIconName;)
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080419/b9696bb8/attachment.sig>
More information about the kde-core-devel
mailing list