[PATCH] KFilePlacesModel : separate storage for custom items and standard items

[nf2]

nf2 wrote:
> Kevin Ottens wrote:
>> Le Thursday 27 March 2008, nf2 a écrit :
>>  
>>> That's intentional. They have to be a 1:1copy (otherwise my comparator
>>> won't work and we might run into an endless synchronization ping pong).
>>> According to the xbel spec it's perfectly ok to have such private
>>> metadata (that's the whole point of the owner= attribute):
>>>     
>>
>> Hmmm, then I forgot to test something, adding something in the 
>> shortcuts.xbel file directly and see how the synchronization cope 
>> with that (it won't have an ID for a start).
>>
>>   
>
> The missing id should be created in such cases.
>
>>  
>>>> Testing your patch I noticed that now the default places have wrong
>>>> icons... Actually after reverting I still see this behavior, so I 
>>>> wonder
>>>> if it could be related to your previous changes to KBookmark.
>>>>       
>
> Yeah - you were right - a stupid "last minute" change in my KBookmark 
> patch caused this problem. I just committed a fix.
>
> So please update, "rm .kde4/share/apps/kfileplaces/bookmarks.xml" and 
> try again...
>
>

Here is an updated patch for KFilePlacesModel. As suggested by Emmanuele 
Bassi, the file-name of the shared bookmarks is "user-places.xbel" now - 
instead of the ambiguous "shortcuts.xbel".

Ok to commit?

Regards,
Norbert





-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfileplaces_fdo_bookmarks_spec4.patch
Type: text/x-patch
Size: 17347 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080413/3e0fd65e/attachment.bin>