KConfig:copyTo + Sync doesn't write to disk (test case)

[Aaron J. Seigo]

On Monday 07 April 2008, Eduardo Robles Elvira wrote:
> The testcase (in the form of a patch for kdelibs/kdecore/tests/) is
> attached; anyone knows why is this happening?

yes. the dirty flag for the config object itself wasn't getting set (just for 
the entries).

this also exposes a flaw in the copyTo/reparent API added for 4.1: it doesn't 
include write flags.

the attached patch fixes both of these things, and your test case now passes 
locally. can you confirm this fixes the issue in your application code as 
well?

btw, because it is BIC (though SC), i can't commit until monday, but will do 
so at that point if there are no complaints.

thanks for the test case (perfect way to report these issues =) and it's good 
we caught this before 4.1 so that we don't have to polute the API with 
duplicate functions, deprecations and KDE5:REMOVEs...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kconfig_copyto.diff
Type: text/x-diff
Size: 4217 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080408/ee3decd8/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080408/ee3decd8/attachment.sig>