[patch] kfilewidget, kurlcompletion, kurl: improve experience of using the file widget

Thiago Macieira thiago at kde.org
Mon Apr 7 17:49:44 BST 2008


On Monday 07 April 2008 14:41:43 Jaroslaw Staniek wrote:
> +    static const QString &prot = KGlobal::staticQString(":/");
> +    for (int i=0; i < len;) {
> +        i = string.indexOf( prot, i );

Please write:

  static const char prot[] = ":/";
...
     i = string.indexOf(QLatin1String(prot), i);

The missing indexOf() function is being added to Qt in Qt 4.5.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080407/7c0d3ef0/attachment.sig>


More information about the kde-core-devel mailing list