[patch] kfilewidget, kurlcompletion, kurl: improve experience of using the file widget
Jaroslaw Staniek
js at iidea.pl
Mon Apr 7 13:41:43 BST 2008
David Faure said the following, On 2008-04-07 11:38:
> On Thursday 03 April 2008, Jarosław Staniek wrote:
>> return u1.toString( options ).toLower() == u2.toString( options ).toLower();
>
> QString::compare( a, b, Qt::CaseInsensitive ) would be faster than two calls to toLower().
>
> Your hasSubUrl optimization should probably use a switch() statement?
>
Good idea. Improved the two things in KUrl (a new patch attached for review).
Another improvement in KUrl:
QString::compare() is also used in KUrl::equals() on Windows.
--
regards / pozdrawiam, Jaroslaw Staniek
Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: urls2.patch
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080407/d1740d66/attachment.ksh>
More information about the kde-core-devel
mailing list