[patch] KToolInvocation: re-enable Windows code, share with UNIX, add invokeTerminal()

Ralf Habacker ralf.habacker at freenet.de
Thu Apr 3 07:23:03 BST 2008


David Faure schrieb:
> On Tuesday 01 April 2008, Ralf Habacker wrote:
>   
>> I can answer these question by myself: invokeTerminal already use such a 
>> configuration switch
>>
>>     KConfigGroup confGroup( KGlobal::config(), "General" );
>>     QString exec = confGroup.readPathEntry("TerminalApplication", 
>> "konsole");
>>
>> for invokeBrowser I suggest to define a 'UseInternalBrowser' flag, for 
>> invokeMailer a 'UseInternalMailer' flag
>>
>>     
>
> There is already a configuration switch for the browser, please don't add a new one...
> krun.cpp:      d->m_externalBrowser = KConfigGroup(KGlobal::config(), "General").readEntry("BrowserApplication");
>
>   
Thanks for this pointer.

<probably little issue found>
Searching a while in that direction let me found that this configuration
options seems to be located in kfmclientrc too

kdebase\apps\konqueror\client\kfmclient.cpp
        KConfig config(QLatin1String("kfmclientrc"));
        KConfigGroup generalGroup(&config, "General");
        if (!generalGroup.readEntry("BrowserApplication").isEmpty())

Should this not be located in kdeglobals too ? If so I would fix this.
</probably little issue found>

Ralf






More information about the kde-core-devel mailing list