Permission for adding KCategorizedSortFilterProxyModel

Allen Winter winter at kde.org
Mon Sep 10 20:31:39 BST 2007


On Monday 10 September 2007 3:07:51 pm you wrote:
> Hi Allen,
> 
> On Monday, 10. September 2007 20:55, Allen Winter wrote:
> > On Monday 10 September 2007 2:47:35 pm Rafael Fernández López wrote:
> > > > Hi all,
> > > >
> > > > I ask for permission for adding KCategorizedSortFilterProxyModel to
> > > > kdelibs/kdeui/itemviews.
> > > >
> > > > It will require changes on kdelibs/kfile/kdirsortfilterproxymodel.
> > > > This class will inherit KCategorizedSortFilterProxyModel instead of
> > > > QSortFilterProxyModel.
> > > >
> > > > The patch that I want to commit is at:
> > >
> > > http://media.ereslibre.es/2007/09/kdeui-10092007.diff
> > >
> > > > Part of the integration can be found on:
> > > >
> > > > http://media.ereslibre.es/2007/09/kdelibs-10092007.diff
> > > > http://media.ereslibre.es/2007/09/kdebase-10092007.diff
> > > >
> > > > but it still needs to be fully integrated.
> >
> > Rafael,
> >
> > Seems like there is big impact on kdelibs and kdebase from the diff's you
> > posted. That concerns me.
> >
> > Should I be worried? or is the impact a lot less than it seems?
> 
> The impact is less than it seems: Currently only Dolphin is concerned and 
> Rafael provided already a patch for Dolphin... But maybe Rafael can speak for 
> himself and comfirm my point of view ;-)
> 
On second look, the impact on kdelibs isn't very big.

It seems Peter is ok with the impact on Dolphin.

And the impact on konqueror is tiny.

Make it so.

-Allen




More information about the kde-core-devel mailing list