KColorScheme - additional (convenience) ctors

Simon Hausmann hausmann at kde.org
Sat Sep 1 22:37:53 BST 2007

On Saturday 01 September 2007 05:17:51 Matthew Woehlke wrote:
> If no one objects, I would like to add additional ctors to KColorScheme
> this Monday (September 3). These will look and behave just like the
> QPalette::ColorGroup ctor, except will take a const QPalette& or const
> QWidget& (effectively they will be the same except will use the current
> state of the QPalette or QWidget), which will make porting from the old
> ctor more convenient (for "proper use" users, anyway).
> Patch attached.

I suggest to change the signature of the constructor that takes a const 
QWidget & to take a const QWidget *. Nobody passes around QWidget references, 
so everyone using this constructor has to dereference the widget to pass for 
no good reason IMHO.

Just a thought,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070901/e2320f84/attachment.sig>

More information about the kde-core-devel mailing list