kconfiggroup and unhandled types

[Thomas Braxton]

On 10/28/07, Aaron J. Seigo <aseigo at kde.org> wrote:
>
> hi...
>
> right now when KConfigGroup can not store a type, such as a QRectF, it now
> aborts with a kFatal().


looks like the code to write QRectF got lost somewhere, it reads them but
doesn't write them?

this seems a bit .... harsh. especially since it means *none* of the config
> gets saved. this resulted in plasma not saving any of its config on exit
> due
> to one data type (QRectF) not being handled.
>
> looking at the code, except for the line in writeConfig which could be
> easily
> guarded with a return and resolve that issue, there would be no
> sideeffects
> to just spitting out a warning and continuing on. only the offending entry
> or
> entries wouldn't be written out, rather than stopping the entire
> application
> and dropping its configuration. that seems a bit overkill to me.
>
> were there specific reasons for using kFatal that warrant keeping it that
> way?


to find/fix cases like this, I'll get right on it, shouldn't take too long

Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071028/0be5c00c/attachment.htm>