kconfiggroup and unhandled types
Aaron J. Seigo
aseigo at kde.org
Mon Oct 29 04:20:34 GMT 2007
hi...
right now when KConfigGroup can not store a type, such as a QRectF, it now
aborts with a kFatal().
this seems a bit .... harsh. especially since it means *none* of the config
gets saved. this resulted in plasma not saving any of its config on exit due
to one data type (QRectF) not being handled.
looking at the code, except for the line in writeConfig which could be easily
guarded with a return and resolve that issue, there would be no sideeffects
to just spitting out a warning and continuing on. only the offending entry or
entries wouldn't be written out, rather than stopping the entire application
and dropping its configuration. that seems a bit overkill to me.
were there specific reasons for using kFatal that warrant keeping it that way?
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071028/b2c879b2/attachment.sig>
More information about the kde-core-devel
mailing list