Getting rid of QT3_SUPPORT in kdeui/xmlgui

[David Faure]

On Tuesday 23 October 2007, Olivier Goffart wrote:
> Le lundi 22 octobre 2007, David Faure a écrit :
> > It was ugly (including passing qt3-like ids in public API), slow, and it
> > broke ENABLE_FINAL compilation. But now it's no more.
> >
> > However this change is binary incompatible (you get to recompile everything
> > since KXmlGuiWindow inherits KXMLGUIBuilder), so I better ask first...
> >
> > I will keep digging for other createContainer() reimplementations than
> > konqueror's, of course, and port them as well (there aren't many according
> > to lxr).
> 
> 
> I don't like the QAction*& argument.
> I would prefer QAction**  
> I think it's better API.

1) Too late
2) Arguable  [what if the given pointer is 0?]
3) Doesn't matter much IMHO - this parameter is not used anywhere out of kdelibs/kdeui.
The method -is- reimplemented in two apps, but they don't use that parameter, they just pass it along.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).