[PATCH] Fixes for KFilePlacesModel and solid's fake backend

[Kevin Ottens]

Hello,

I have two patches pending for kdelibs.

1) solid_fix_fakebackend_storageaccess.patch
This one add the support for the StorageAccess interface in the fake backend 
of solid. It is necessary to write useful unit tests for code having to deal 
with storage devices (like dolphin, kfileplacesmodel, etc.).

2) kfile_fix_kfileplacesmodel_behavior.patch
This patch is a rework of KFilePlacesModel, no interface change, it's 
completely BC. It was needed because KFilePlacesModel behavior was very bad, 
in particular regarding signals, any change resulted in a complete relisting 
from the view... To produce this patch I first added a lot of unit tests 
(were lacking) mapping the old behavior of KFilePlacesModel (except for 
signals). Then I progressively added the tests regarding signals to go toward 
the intended behavior. So it shouldn't introduce any regression, only a saner 
behavior regarding the way it emits signals.

I'll wait for objections until monday to commit this (I plan to commit on 
monday evening to give people some room to stop me... otherwise it'd be 
already committed). ;-)

Since I'm at it, I'm requesting the rights to commit a few changes in kdelibs 
without patch review first (since I know we're supposed to be close of yet 
another freeze):
 - In KFilePlacesView, the animations need to be finished, it's currently to 
slow and consuming too much resources due to the performances of KIcon and 
the fact that it resizes a lot. So I'd like to commit the needed polishing in 
this department (basically modify the implementation of the appear animation, 
add the disappear animation, it'll probably require some internal refactoring 
to get it right).
 - In KFilePlacesModel, improve the support for crypto volumes and the way 
change in mount status are handled. Currently they're not optimal usability 
wise (too much stuff seen for crypto volumes which is confusing, and no 
mount/unmount state indication for volumes in general). It'll probably 
require completing the support for StorageAccess in the fake backend of solid 
(for the unit tests).
 - In Solid::Backends::Hal::HalDevice, I'd like to tune the icon() method, 
since for now it's definitely not precise enough (for instance floppies have 
a harddisk icon...).

So yeah, it's all in the GUI polishing and bugfixing department around a class 
from kdelibs which is supposed to be seen at several places: mainly dolphin 
sidebar and KFileDialog, but also used by some engines in plasma.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kfile_fix_kfileplacesmodel_behavior.patch
Type: text/x-diff
Size: 48554 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071020/1734a987/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: solid_fix_fakebackend_storageaccess.patch
Type: text/x-diff
Size: 11434 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071020/1734a987/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071020/1734a987/attachment.sig>