KAboutData Nit

Albert Astals Cid aacid at kde.org
Fri Oct 12 14:02:05 BST 2007


A Divendres 12 Octubre 2007, Sebastian Kügler va escriure:
> On Friday 12 October 2007 13:26:28 Albert Astals Cid wrote:
> > A Divendres 12 Octubre 2007, Sebastian Kügler va escriure:
> > > On Thursday 11 October 2007 19:50:36 Allen Winter wrote:
> > > > The "ThanksTo" tab contents are a bit messed-up.
> > > > See the attached screenshot.
> > > >
> > > > The first name listed is left justified and does not
> > > > have a blank line afterward.
> > >
> > > Before this discussion becomes too academical, can I commit the
> > > following patch?
> >
> > No, that completely breaks the look we want to have.
> >
> > We want
> >
> > Name1
> >   Email1
> >   Web1
> >   Description1
> >
> > Name2
> >   Email2
> >   Web2
> >   Description2
> >
> > The correct workaround is not adding the empty <p></p> if there is not
> > email nor web nor description.
>
> Attached patch defines the margins per line, it's not semantically perfect,
> but the syntax is correct and rendered well, see the following screenshots:
>
> http://vizzzion.org/tmp/korganizer-about.png
> http://vizzzion.org/tmp/kwrite-about.png
>
> Should I commit this patch then?
>
> I can also make using the <p> conditional, but it won't make the code look
> more beautiful, IMO.

Seems fine to me.

Albert




More information about the kde-core-devel mailing list