KAboutData Nit

Sebastian Kügler sebas at kde.org
Fri Oct 12 13:43:50 BST 2007


On Friday 12 October 2007 13:26:28 Albert Astals Cid wrote:
> A Divendres 12 Octubre 2007, Sebastian Kügler va escriure:
> > On Thursday 11 October 2007 19:50:36 Allen Winter wrote:
> > > The "ThanksTo" tab contents are a bit messed-up.
> > > See the attached screenshot.
> > >
> > > The first name listed is left justified and does not
> > > have a blank line afterward.
> >
> > Before this discussion becomes too academical, can I commit the following
> > patch?
>
> No, that completely breaks the look we want to have.
>
> We want
>
> Name1
>   Email1
>   Web1
>   Description1
>
> Name2
>   Email2
>   Web2
>   Description2

> The correct workaround is not adding the empty <p></p> if there is not
> email nor web nor description.

Attached patch defines the margins per line, it's not semantically perfect, 
but the syntax is correct and rendered well, see the following screenshots:

http://vizzzion.org/tmp/korganizer-about.png
http://vizzzion.org/tmp/kwrite-about.png

Should I commit this patch then?

I can also make using the <p> conditional, but it won't make the code look 
more beautiful, IMO.
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kaboutapplication-fix-html2.diff
Type: text/x-diff
Size: 3824 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071012/1a8d0856/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071012/1a8d0856/attachment.sig>


More information about the kde-core-devel mailing list