list separator in config entries

Thomas Braxton kde.braxton at gmail.com
Tue Oct 9 20:34:00 BST 2007


On 10/9/07, Andreas Hartmetz <ahartmetz at gmail.com> wrote:
>
> 2007/10/9, Thomas Braxton <kde.braxton at gmail.com>:
> >
> >
> > On 10/8/07, Andreas Pakulat <apaku at gmx.de> wrote:
> > > On 08.10.07 14:20:13, Thomas Braxton wrote:
> > > > On 10/8/07, Andreas Pakulat <apaku at gmx.de> wrote:
> > > > >
> > > > > On 08.10.07 12:27:57, Thomas Braxton wrote:
> > > > > > I know what was being pondered on this thread, but if I don't
> > understand
> > > > > > what you think is broken then I can't fix it can I?
> > > > >
> > > > > Exactly what is tested in the test. KConfig doesn't properly store
> a
> > > > > list of strings if one of the strings has a \ at the end. I'm at
> the
> > > > > moment not sure wether reading or writing or both are broken for
> this,
> > > > > i.e. wether it doesn't escape the backslash or doesn't realize
> that
> > this
> > > > > is not an escaped list-separator but in fact a list entry ending
> in a
> > > > > backslash and a list separator afterwards.
> > > >
> > > > does this work in KDE3?
> > >
> > > Yes it does, so in fact this is a regression that absolutely needs
> > > fixing.
> >
> >
> > ok, it'll be fixed by morning.
> >
> Do we have a misunderstanding here? We are working on it. We are four,
> and we know the problem. Admittedly, PutHuhn is working on it and the
> other Andreas, Ossi, and me are watching and giving suggestions. So
> *please* either communicate with us, preferably on IRC, or refrain
> from committing things without asking around before. It's *not* about
> fixing two lines of code.
> If you want to post a patch to this thread, go ahead.
>
fixed yet? if not here's a patch that fixes it. it uglifies the stringlists
that contain entries that end with backslash, but it works and storing
entries that end with backslash shouldn't be very common.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/c95d4aff/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: listfix.diff
Type: application/octet-stream
Size: 1878 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/c95d4aff/attachment.obj>


More information about the kde-core-devel mailing list