KDE Printing API Request

[Alex Merry]

On Monday 08 Oct 2007, Thomas Zander wrote:
> On Monday 08 October 2007 08:18:23 Thomas Zander wrote:
> > > Thomas has the details on how to do the modifications.
> >
> > Yap,  I'll propose a patch soon.
>
> I'm working on it now, using your (Alex') patch as a framework.
> I have two little problems with the proposed patch I got from your
> mail; you suggest passing a QList<QWidget> customTabs
> I think that should be const QList<QWidget*> &customTabs.
>
> Second; the files are LGPL v2.
> I would really like that to be LGPLv2+
>
> Ok to change those two things?

By all means.

>
> One more thing, the proposed API is  'getPrintingDialog()'  while its
> a factory method; is that normal in Kdelibs?  I'm used to factory
> methods being called 'createFoo' (where factory method means that the
> caller immediately takes responsibility for deleting the thing)

You're right.  createPrintingDialog is probably better, especially as 
creating it is what it does :-)

Actually, even better would be createPrintDialog, to fit with the 
AbstractPrintDialog that is returned.

Alex



-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/20ea16ca/attachment.sig>