[Patch] KUrl::prettyUrl and xmpp: url

[Olivier Goffart]

Le lundi 8 octobre 2007, Thiago Macieira a écrit :
> Olivier Goffart wrote:
> >Thanks, I have committed.
>
> Thank you. I'm late to say so, but the patch is ok.
>
> >Anyway, another question comes to me : Why is the pretty URL passed to
> > the application, and not the real URL? I mean, if a link contains a
> > password, it make sens to pass the password to the application.
>
> Pretty URLs are never passed from machine to machine. It's meant for human
> consumption only. It is not a safe transformation because it discards
> data as well as making it slightly broken.
>
> >KRun replace %u by KUrl::pathOrUrl() which uses prettyUrl()
> >the documentation of pathOrUrl say it is used for user display, so we
> > should not use that in KRun.
>
> Indeed. pathOrUrl() seems to be broken: it should return path() or url().
> Otherwise, it should be called pathOrPrettyUrl().

So do you suggest me to fix pathOrUrl()  (and his documentation)
Or do I commit the previous patch ?

> >So I've replaced pathOrUrl by url() in KRun,  the side effect is that
> > local files will have file:/// prefix, but i think application should
> > cope with this.  Or should we try to remove the file:/// from urls
> > anyway ?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071008/efd77e50/attachment.sig>