[PATCH] KFileItemDelegate API change

Allen Winter winter at kde.org
Mon Oct 1 20:06:18 BST 2007


On Monday 01 October 2007 2:43:10 pm Fredrik Höglund wrote:
> On Monday 01 October 2007 20:33, David Faure wrote:
> > On Monday 01 October 2007, Fredrik Höglund wrote:
> > > +        void setShowInformation(InformationList list);
> > should take a const ref. Looks good to me, otherwise :)
> 
> Good point, I'll change that.
> 
> > > next Monday if no one objects.
> > I heard rumours about a freeze on 03 October...
> 
That's not a rumor.

> I'm aware of the freeze, but Allen said in his email that the total freeze
> isn't until 19 October, and reviewed patches are allowed until then.
> It's not clear to me what kind of changes are permitted in those patches
> though.
>
I'll send a separate email where I try to be more specific.

> But I could leave out the implementation, and just change the API if this
> is considered a new feature.
> 
Please commit today.   Especially since David and Peter already like what you did.

-Allen




More information about the kde-core-devel mailing list