[PATCH/RFC] KMultiTabBar surgery...

[Christoph Cullmann]

On Monday 01 October 2007 06:12, Maksim Orlovich wrote:
> Hi... When looking at fixing major problems in painting of konq's sidebar
> in trunk (#148192, perhaps others), I quickly diagnosed it to KMultiTabBar
> widget in kdeui, which is also used in Kate. Unfortunately, it's currently
> in a rather bad state --- it has tons of methods that don't do anything,
> unused modes that do weird things, etc. Worse, its basic operation mode is
> to hard code width to 24 pixels. This of course is very wrong since
> accessibility may require a larger font (plus it has its own,
> ultra-complex layout code). In short, the attached removes most of these
> things. Most of the interesting work now is done by Qt layouts, and the
> toggle-tab widgets provide appropriate size hint and painting. One cost of
> this change is that when widgets do not fit, it no longer goes into a
> multi-line mode --- but it can squeeze the label text instead. In my
> experience it worked well for kate w/all the plugins I have enabled. API
> changes are just removing redundancy, unused methods of dubious values and
> methods that did not do anything. Porting patches attached.
>
> Anyway, I will commit this monday night EST if no one has a big issue with
> it -- but I'd welcome feedback, especially from the Kate folks in case the
> details aren't quite to their taste.
I am all for it :=) KMultiTabBar is the "worst" part of the Kate UI, I mostly 
chosen it, as it allows multiple tabs to be selected at once, which is 
needed. I doubt Kate uses the "multiple rows of text" wrapping and any 
improvement is welcome to rendering. I have not tested the patches for the 
look'n'feel, but if you say it looks well, I trust you. (given the current 
state, I doubt there can be any worse look possible...)

cu
Christoph

-- 
-------------------------------------- Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel at kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel