[PATCH/RFC] KMultiTabBar surgery...

Maksim Orlovich mo85 at cornell.edu
Mon Oct 1 05:12:48 BST 2007


Hi... When looking at fixing major problems in painting of konq's sidebar
in trunk (#148192, perhaps others), I quickly diagnosed it to KMultiTabBar
widget in kdeui, which is also used in Kate. Unfortunately, it's currently
in a rather bad state --- it has tons of methods that don't do anything,
unused modes that do weird things, etc. Worse, its basic operation mode is
to hard code width to 24 pixels. This of course is very wrong since
accessibility may require a larger font (plus it has its own,
ultra-complex layout code). In short, the attached removes most of these
things. Most of the interesting work now is done by Qt layouts, and the
toggle-tab widgets provide appropriate size hint and painting. One cost of
this change is that when widgets do not fit, it no longer goes into a
multi-line mode --- but it can squeeze the label text instead. In my
experience it worked well for kate w/all the plugins I have enabled. API
changes are just removing redundancy, unused methods of dubious values and
methods that did not do anything. Porting patches attached.

Anyway, I will commit this monday night EST if no one has a big issue with
it -- but I'd welcome feedback, especially from the Kate folks in case the
details aren't quite to their taste.

-Maks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmultitabbar_kdelibs.diff
Type: text/x-diff
Size: 42596 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071001/0e9bd883/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmultitabbar_kdesdk.diff
Type: text/x-diff
Size: 648 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071001/0e9bd883/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmultitabbar_kdebase.diff
Type: text/x-diff
Size: 637 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071001/0e9bd883/attachment-0002.diff>
-------------- next part --------------
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel at kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


More information about the kde-core-devel mailing list