KWidgetJobTracker changes [bugfix] (was: kcmshell4 kthememanager baddies)

David Faure faure at
Wed Nov 28 21:24:20 GMT 2007

On Wednesday 28 November 2007, Rafael Fernández López wrote:
> > Yep, looks fine. Just one thing:
> > see, the one advantage of having renamed the variable to "q" as I suggested
> > on irc is that now I see
> >   q->d->
> > in the destructor and that looks obviously unnecessary :-)
> Not so obvious... I mean...
> q->d-> is in class KWidgetJobTracker::Private::ProgressWidget
> Where q is of type KWidgetJobTracker* and d is of type 
> KWidgetJobTracker::Private*
> On the constructor of KWidgetJobTracker::Private::ProgressWidget a 
> KWidgetJobTracker* is passed and assigned to q, for that reason it is needed 
> a q->d if we do not want to add another parameter for a type 
> KWidgetJobTracker::Private*.

Ah ok ;)
Then I was wrong on irc, it's not a "q" pointer (a pointer from the private class to its public class).

David Faure, faure at, sponsored by Trolltech to work on KDE,
Konqueror (, and KOffice (

More information about the kde-core-devel mailing list