KDialog and Reset buttons

Olivier Goffart ogoffart at kde.org
Wed Nov 28 17:14:03 GMT 2007

Le mercredi 28 novembre 2007, Aaron J. Seigo a écrit :
> hi all
> it was pointed out by a user on irc that the Reset button in systemsettings
> is in the wrong place, causing them to click on it all the time (muscle
> memory really sucks sometimes ;)
> i looked at the code and it turns out the culprit is KDialog. it does not
> have support for the Reset button, even though there is such a button role
> in QDialogButtonBox and many HIGs have a defined place for it (with the
> Default button, usually).
> attached is a patch that fixes this usability bug by adding Reset as a well
> known button in KDialog.
> i also have a patch to make systemsettings use this instead of User1 (which
> puts it in the ActionRole area rather than the ResetRole area, ergo the
> bug)
> may i commit?

Ok for me.

Althought I would have give the value 0x200 or 0x800 instead of 0x10000 to 
keep it next to others normal values,  but that's bikesheed color.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071128/559f4c1f/attachment.sig>

More information about the kde-core-devel mailing list