KDialog and Reset buttons

Aaron J. Seigo aseigo at kde.org
Wed Nov 28 16:45:54 GMT 2007

hi all

it was pointed out by a user on irc that the Reset button in systemsettings is 
in the wrong place, causing them to click on it all the time (muscle memory 
really sucks sometimes ;)

i looked at the code and it turns out the culprit is KDialog. it does not have 
support for the Reset button, even though there is such a button role in 
QDialogButtonBox and many HIGs have a defined place for it (with the Default 
button, usually).

attached is a patch that fixes this usability bug by adding Reset as a well 
known button in KDialog.

i also have a patch to make systemsettings use this instead of User1 (which 
puts it in the ActionRole area rather than the ResetRole area, ergo the bug)

may i commit?

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdialog_reset.diff
Type: text/x-diff
Size: 1925 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071128/089f4f63/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071128/089f4f63/attachment.sig>

More information about the kde-core-devel mailing list