inactive selection change

Matthew Woehlke mw_triad at users.sourceforge.net
Tue Nov 20 01:26:00 GMT 2007


Ok, I guess I am convinced having inactive selection colors exactly 
equal to inactive window colors doesn't work so well.

So, how can we do this right? The obvious solution is to make inactive 
selection a new color group... bleh, not my first choice.

Instead, here's a patch to try out. This keeps the current behavior with 
one modest change: the Inactive:Selection:NormalBackground and 
AlternateBackground colors are tinted toward the Active:S:NBg color. 
This way inactive selections have the luma characteristics of Window 
colors, but the background is biased towards A:S:NBg, which is IMO 
really what is most expected. Selections still look like selections, but 
it is still easy to tell when the selection is inactive.

Ok to commit? This is BC+SC as far as I can tell. (Hopefully it is even 
good enough that we can revert some of the 'always use active' hacks, 
e.g. in KFileDialog...)

See also http://bugs.kde.org/show_bug.cgi?id=152128#c11

-- 
Matthew
Warning: prolonged exposure to Linux may cause addiction.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inactive-selection.patch
Type: text/x-patch
Size: 4099 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071119/bb0325ae/attachment.bin>


More information about the kde-core-devel mailing list