Adding simple API / freeze in effect?

Thomas Friedrichsmeier thomas.friedrichsmeier at ruhr-uni-bochum.de
Wed Nov 14 23:33:35 GMT 2007


On Thursday 15 November 2007, Aaron J. Seigo wrote:
> this: 
> 
> +  for (QMap<QAction*, KUrl>::ConstIterator it = d->m_urls.constBegin();
> it != d->m_urls.constEnd(); ++it)
> +    ret.append(it.value());
>
> does not adhere to the style guidelines which say {}s even for one-liners =) 
> personally i'd write it to just be:
> 
> foreach (const KUrl& url, d->m_urls) {
>    ret.append(url);
> }

Alright. I just imitated the "bad" style from removeUrl() directly above. Ok 
to commit in prettified form, then?

Regards
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071115/29a1c286/attachment.sig>


More information about the kde-core-devel mailing list