Adding simple API / freeze in effect?

[Aaron J. Seigo]

On Wednesday 14 November 2007, Thomas Friedrichsmeier wrote:
> Note: Technically replying to my own mail, as I have list delivery
> disabled, ATM.
>
> On Wednesday 14 November 2007, Dirk Mueller wrote:
> > On Wednesday 14 November 2007, Thomas Friedrichsmeier wrote:
> >> just a quick question, as I've not been following KDE core development,
> >> but just ran into a small issue while porting RKWard to KDE4: Is it ok
> >> to add some simple API in kdelibs?
> >
> > adding API is possible unless its virtual. Please post a patch for review
> > (especially one including api docs) :)
>
> Here you go, patch attached (diff is relative to kdelibs).

this: 

+  for (QMap<QAction*, KUrl>::ConstIterator it = d->m_urls.constBegin(); it != 
d->m_urls.constEnd(); ++it)
+    ret.append(it.value());

does not adhere to the style guidelines which say {}s even for one-liners =) 
personally i'd write it to just be:

foreach (const KUrl& url, d->m_urls) {
    ret.append(url);
}

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071114/20d6702a/attachment.sig>