KMimeType::isBufferBinaryData() is broken

David Faure faure at kde.org
Sun May 6 21:29:23 BST 2007


On Saturday 05 May 2007, Andreas Pakulat wrote:
> On 05.05.07 20:22:35, Ralf Habacker wrote:
> > Andreas Pakulat schrieb:
> > >Hi,
> > >
> > >just found out that isBufferBinaryData fails to recognize plain/text
> > >when there's a linefeed in the first 32 bytes. IMHO the check should
> > >check for bytes in the range 00-0A, 0B-0C and 0E-1F, i.e. leave out
> > >linefeed and carriage return. Those two ascii control characters are
> > >valid in plain/text.
> > >
> > >The attached patch does this, objections against committing?
> > >  
> > either the line
> > +        char c = p[i];
> 
> Ooops, I just added that line for some debugging :) Of course it won't
> be in the final commit.

Patch looks fine; my mistake.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list