KMimeType::isBufferBinaryData() is broken
apaku at gmx.de
Sat May 5 20:26:37 BST 2007
On 05.05.07 20:22:35, Ralf Habacker wrote:
> Andreas Pakulat schrieb:
> >just found out that isBufferBinaryData fails to recognize plain/text
> >when there's a linefeed in the first 32 bytes. IMHO the check should
> >check for bytes in the range 00-0A, 0B-0C and 0E-1F, i.e. leave out
> >linefeed and carriage return. Those two ascii control characters are
> >valid in plain/text.
> >The attached patch does this, objections against committing?
> either the line
> + char c = p[i];
Ooops, I just added that line for some debugging :) Of course it won't
be in the final commit.
Bank error in your favor. Collect $200.
More information about the kde-core-devel