EBN fixes (kwallet)

George Staikos staikos at kde.org
Sun Mar 18 14:23:57 GMT 2007


The backend patches are unnecessary.  That's an internal library.

On 17-Mar-07, at 8:00 PM, Alex Merry wrote:

> I split this into backend and client patches, because I'm thinking bc
> may only be an issue for the client part, in which case it's probably
> not worth changing the backend stuff (all marked @internal), and risk
> introducing bugs, as well as reducing readability etc.
>
> I'd appreciate someone with knowledge of kwallet looking over it.   
> I did
> quite a bit of refactoring code to put private members in a d-pointer,
> and I don't claim to understand the code completely.  That said, it  
> was
> largely mechanical work, I was reasonably thorough in checking the
> results of the substitutions by eye, and it all compiles fine, without
> any relevant warnings.  And the wallet seems to actually work.
>
> Alex :-)
> <kdelibs-kwallet-backend-ebn-fixes.diff>
> <kdelibs-kwallet-client-ebn-fixes.diff>

--
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/







More information about the kde-core-devel mailing list