EBN fixes (kwallet)

Alex Merry alexander.merry at ccc.ox.ac.uk
Sun Mar 18 00:00:52 GMT 2007


I split this into backend and client patches, because I'm thinking bc 
may only be an issue for the client part, in which case it's probably 
not worth changing the backend stuff (all marked @internal), and risk 
introducing bugs, as well as reducing readability etc.

I'd appreciate someone with knowledge of kwallet looking over it.  I did 
quite a bit of refactoring code to put private members in a d-pointer, 
and I don't claim to understand the code completely.  That said, it was 
largely mechanical work, I was reasonably thorough in checking the 
results of the substitutions by eye, and it all compiles fine, without 
any relevant warnings.  And the wallet seems to actually work.

Alex :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-kwallet-backend-ebn-fixes.diff
Type: text/x-diff
Size: 29635 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070318/a297f91b/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-kwallet-client-ebn-fixes.diff
Type: text/x-diff
Size: 14503 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070318/a297f91b/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070318/a297f91b/attachment.sig>


More information about the kde-core-devel mailing list