kfilemetainfo progress

Richard Moore richmoore44 at gmail.com
Sat Mar 3 20:43:51 GMT 2007


A few quick comments:

- Could we make the name of the enum 'What' a bit more descriptive?

- Could ExtenedAttr be ExtenededAttr or even ExtenededAttributes

- Do we need a range reserved for custom values in that enum? Not sure
if that is needed though.

- Having a long constructor like KFileMetaInfo(const QString& path,
const QString& mimetype = QString(),  What w = Everything); rather
than a short one and some set methods goes against the general KDE
libs policy. Is there a particular reason it is written like that?

Cheers

Rich.




More information about the kde-core-devel mailing list