Why does FindQt4.cmake add a link dependency of QtScript to QtUiTools?

Thiago Macieira thiago at kde.org
Wed Jun 20 20:16:15 BST 2007


Andreas Pakulat wrote:
>I could convince Thiago that this has changed since he last looked.
>QtUiTools now doesn't include the formscriptrunner class anymore and
>thus doesn't link against QtScript. The attached patch removes the hack
>from FindQt4.cmake that added the QtScript library to
>QT_QTUITOOLS_LIBRARY variable.
>
>Objections against comitting?

I opposed the addition of this code when it first came in, but accepted it 
because it was a necessity.

Since it's no longer necessary, yes, please, by all means remove it!

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070620/4bab26ac/attachment.sig>


More information about the kde-core-devel mailing list