Why does FindQt4.cmake add a link dependency of QtScript to QtUiTools?

[Andreas Pakulat]

On 20.06.07 10:42:02, Richard Dale wrote:
> I found my library had an unexpected link dependency on QtScript even though 
> there was no mention of QtScript in the CMakeLists.txt file. After 
> investigating a bit I found these lines in FindQt.cmake:
> 
>   IF(QT_QTSCRIPT_LIBRARY AND QT_QTUITOOLS_LIBRARY)
>     SET(QT_QTUITOOLS_LIBRARY ${QT_QTUITOOLS_LIBRARY} ${QT_QTSCRIPT_LIBRARY} )
>   ENDIF(QT_QTSCRIPT_LIBRARY AND QT_QTUITOOLS_LIBRARY)
> 
> WTF? I've no idea what problem this is trying to solve as there is no comment 
> against it. But it just seems plain wrong to me and should be removed.

I could convince Thiago that this has changed since he last looked.
QtUiTools now doesn't include the formscriptrunner class anymore and
thus doesn't link against QtScript. The attached patch removes the hack
from FindQt4.cmake that added the QtScript library to
QT_QTUITOOLS_LIBRARY variable. 

Objections against comitting?

Andreas

-- 
It was all so different before everything changed.
-------------- next part --------------
Index: FindQt4.cmake
===================================================================
--- FindQt4.cmake	(Revision 677983)
+++ FindQt4.cmake	(Arbeitskopie)
@@ -803,10 +803,6 @@ IF (QT4_QMAKE_FOUND)
     _QT4_ADJUST_LIB_VARS(QTMAIN)
   ENDIF(WIN32)
 
-  IF(QT_QTSCRIPT_LIBRARY AND QT_QTUITOOLS_LIBRARY)
-    SET(QT_QTUITOOLS_LIBRARY ${QT_QTUITOOLS_LIBRARY} ${QT_QTSCRIPT_LIBRARY} )
-  ENDIF(QT_QTSCRIPT_LIBRARY AND QT_QTUITOOLS_LIBRARY)
-
   #######################################
   #
   #       Check the executables of Qt