Extending KSettings::Dialog to allow to specify excludes

[Aaron J. Seigo]

On Wednesday 20 June 2007, Andreas Pakulat wrote:
> Ok, here's the updated patch, 

looks good ... some nitpicks (sorry *eek*):

- i'd probably just call it "set*" rather than "initialize*". yes, it's only 
an initializer right now, but the apidox can note that implementation detail 
right now and if it does change in the future (mkretz seemed to note that 
this was on his radar to eventually do) we won't be left with 
innappropriately named methods ...

- after blacklisted = true you could probably put a break; to avoid further 
looping when we already know the result

- could you adjust the code to follow the kdelibs style guide? =)
	 http://techbase.kde.org/Policies/Kdelibs_Coding_Style

> as I said I also moved the argument-list 
> out of the constructor as its not needed there (wonder what drove me to
> put it there). 

hehe.. force of habit, perhaps .. it has taken me a while to get used to the 
new approaches (and i'm still getting used to some aspects of it)

> Also the new functions now have proper apidox. 

long live the dox! =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070620/daa14397/attachment.sig>