KFileWidget patch

David Faure faure at kde.org
Tue Jun 19 09:32:33 BST 2007


On Sunday 17 June 2007, Albert Astals Cid wrote:
> Hi, i know i promised never to code another kdelibs patch, but hey, 
> KFileWidget was failing and i had nothing better to do on a satuday night, 
> so...
> 
> The problem:
>  Using KFileDialog to open the second (actually not the first) suggested item 
> in completion does not work, it always opens the first.
> 
> Steps to reproduce the problem:
>  * Open okular
>  * File->Open
>  * Go to a dir with some pdf files beginning with a
>  * Type a in the location field
>       afoo.pdf
>       abar.pdf
>    appear on the suggestions box
>  * Press down to select the second suggested entry
>  * Press enter
>  * afoo is opened
> 
> The problem is that setSelection was not beign called because the activated 
> signal of the lineedit is not emited.
> 
> My patch changes a bit how things work, but i could not find any regression 
> and it fixes the problem for me.

The dialog/widget split did change a bit how things work, and is probably the reason
for this problem. Thanks for the fix, please commit.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list