KDE/kdelibs/kdecore

[David Faure]

On Thursday 14 June 2007, Holger Schröder wrote:
> On Wednesday 13 June 2007 10:43:45 David Faure wrote:
> > On Tuesday 12 June 2007, Christian Ehrlicher wrote:
> > > Oswald Buddenhagen schrieb:
> > > > SVN commit 673882 by ossi:
> > > >
> > > > there is no point in pretending that k3proc* is not unix-specific.
> > > > also, don't install kpty.h on non-unix.
> > >
> > > and now?
> > > K3Process is used in kedui/dialogs/kedittoolbar.cpp -> it's no longer
> > > compilable on non unix :-(
> >
> > I'll port KEditToolBar to QProcess. It starts kdialog with NotifyOnExit and
> > reads the stdout of the process to get the name of the selected icon,
> > shouldn't be a big problem to do that with QProcess, I assume.
>
> perhaps this question is silly, but why is this dialog implemented in an own 
> process at all ?
It's not. The dialog is in kdeui. But when you click on "change icon" then you need
an icon selector (KIconDialog), which itself needs a file dialog, which is why it is 
implemented with KProcess() << "kdialog --geticon ...".

We can nowadays dlopen libkfile but that wouldn't help much, KIconDialog and 
KFileDialog are in libkio; moving them to libkdeui seems like much trouble for 
a problem that's already solved differently, IMHO.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).