[PATCH] Konqueror crash

Rafael Fernández López ereslibre at gmail.com
Wed Jun 6 16:29:37 BST 2007


Hi all,

Testing kuiserver I got an assert failure at kdelibs/kio/kio/job.cpp:1862.
To reproduce the problem:

- Open Konqueror
- Start a file download
- Pause it
- Resume it, and boom !!

Ok, as far as I have gone (don't really know if it is OK, for that reason
I'm writing here), is that is probably that m_getJob at that point is ready,
but m_putJob isn't. I couldn't find any reason of why we would need m_getJob
to emit data signal.

With this patch everything seems to work correctly (as far as I have tested)
and the assert failure seems gone too.


Bye,
Rafael Fernández López.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070606/16800843/attachment.htm>
-------------- next part --------------
Index: kio/job.cpp
===================================================================
--- kio/job.cpp	(revisi��n: 672228)
+++ kio/job.cpp	(copia de trabajo)
@@ -1832,8 +1832,6 @@ void FileCopyJob::slotCanResume( KIO::Jo
             connectSubjob( m_getJob ); // Progress info depends on get
             m_getJob->internalResume(); // Order a beer
 
-            connect( m_getJob, SIGNAL(data(KIO::Job*,const QByteArray&)),
-                     SLOT( slotData(KIO::Job*,const QByteArray&)) );
             connect( m_getJob, SIGNAL(mimetype(KIO::Job*,const QString&) ),
                      SLOT(slotMimetype(KIO::Job*,const QString&)) );
         }


More information about the kde-core-devel mailing list