Request for Review: KExpandableWidget into kdeui

[Daniel Molkentin]

Am Mittwoch 25 Juli 2007 schrieb Benjamin Meyer:
> Don't want these in the header:
> #include <QtGui/QScrollArea>
> #include <QtGui/QLabel>
> #include <QtCore/QDebug>
> class QScrollArea;

Yes, those are leftovers from ancient times.

> @return widgets wether the widget is collapsed or not
> stormy outside :)

Better adjust api docs when chaning class semantics :)

> move init() into the private class

Done already.

> widget/setWidget are very generic, but I am not sure of better name,
> perhaps something like containedWidget()

It used to be setInnerWidget()(innerWidget(). setCentralWidget() like in 
QMainWindow sounds too bold imho. containedWidget() would be an idea indeed,  
but it has no precedence in the Qt API. Do you think I should rename it 
anyways?

Cheers,
  Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070725/a6d5d106/attachment.sig>