Update on KIO & KSSL

Thiago Macieira thiago at kde.org
Mon Jul 23 15:48:12 BST 2007


I have started working on KIO to try and clean it up a bit. I have already 
committed this night an initial patch that makes all the d-pointers be 
shared in the KIO::Job tree.

However, this code is rather old and is not using d-pointers at all. Most 
of the member variables are protected or private in the class itself. It 
also has many protected/private slots, including protected virtual slots 
(and this bad practice comes all the way from KJob). There's also a lot 
of duplicated code that handles redirections, the job finish and meta 
data.

I have in my local tree finished converting KIO::Job, SimpleJob, StatJob, 
MkdirJob, TransferJob. There are a few more *Job to go and I could 
complete this today. But I'd rather not rush it. With another week, I 
could properly fix this.

I should point out that all of this is about KIO::Job *internals*. It has 
nothing to do with the public API of the classes, despite the fact that 
all of this is publicised and exported.

So, I don't want to ask for an extension of the deadline for the kdelibs 
freeze. Therefore, I ask: is this work on KIO::Job internals still 
allowed after today? The code is working and doesn't have to change -- I 
just thing it should.

And about KSSL: someone has to work on it. I said I'd do it, but I still 
have not found the will to start working on it. I do have the will to 
work on KIO::Job though.

PS: the direct result of these changes I'm making is that there can be no 
other KIO::*Job from outside kdelibs. I think it's reasonable. IOSlave 
extensions can be done via the special() command.
-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070723/1839f89e/attachment.sig>


More information about the kde-core-devel mailing list