kdelibs/khtml EBN

[Alex Merry]

On Tuesday 17 Jul 2007, Jeff Anderson wrote:
> I noticed on EBN that khtml_settings.h contains 4 places where
> methods return const references.  According to the policy, I changed
> these. Since this is my first ever KDE patch, someone please tell me
> if I got it right ;-)

You also need to change the definitions in khtml_settings.cc.

You should have got errors when you tried to compile kdelibs (tip: 
always recompile after making a change before committing/sending a 
patch).

Alex


-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070718/35849512/attachment.sig>