proposed KAction/KActionCollection API changes

[Thomas Zander]

On Wednesday 03 January 2007 00:21, Ellis Whitehead wrote:
> > 1) KAction and its subclasses get the same 3 (compatible) constructors...
> > 2) Actions need to be explicitly added to the actioncollection...
>
> For a long list of actions, I still find the table-like actions lists
> like in Olivier email *much much* easier to read than 3 or 4 lines of
> code per action.  I personally wouldn't be want to lose the
> possibility for these concise definitions.

Based on working with people that try to focus on _their_ piece of the 
software I think you are looking from the perspective of someone that is too 
familiar with the different constructors.
From the perspective of people that don't want to learn kaction constructor 
order from memory, that way is actually harder to write and maintain, and 
most certainly harder to read.

So, for the same reason you would choose a normal indenting style and readable 
variable names, you should focus on using simpler constructors. With that I 
mean both shorter (less arguments) constructors and less choice of different 
constructors.

-- 
Thomas Zander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070103/53a84ecd/attachment.sig>