Crash fix for KParts::PartManager

Andreas Pakulat apaku at gmx.de
Tue Feb 20 12:01:17 GMT 2007


On 20.02.07 11:02:26, Thomas Zander wrote:
> On Monday 19 February 2007 01:25, Andreas Pakulat wrote:
> > just found that KPart::PartManager::addPart happily crashes when handed
> > a 0-pointer. While one could argue that this shouldn't happen in the
> > first place its also not nice to just crash in this case. The patch
> > below adds a check and a kfatal output.
> >
> > If nobody objects I'll commit that on tuesday.
> 
> Sorry, I don't read k-c-d even day. Waiting a little longer next time would be 
> appreciated. Especially when its a holiday ;)

Oh, I wasn't aware of holidays around this time :)

> Please replace the if construct with a single
>  Q_ASSERT(part);

Done.

Andreas

-- 
You will visit the Dung Pits of Glive soon.




More information about the kde-core-devel mailing list